certificate_packs: deprecate "custom" in favour of ACM #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by cloudflare/cf-terraforming#443 validation mismatches, I went ahead and updated `CertificatePacks` to only reference ACM configuration now that dedicated custom/custom certificates are no more.
|
changelog detected ✅ |
|
@nickysemenza do you mind eyeballing this one for me? we had some failures in cf-terraforming which lead me here to clean up the structs and methods. |
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 49.06% 49.14% +0.08%
==========================================
Files 108 111 +3
Lines 10428 10516 +88
==========================================
+ Hits 5116 5168 +52
- Misses 4200 4224 +24
- Partials 1112 1124 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This functionality has been released in v0.47.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by cloudflare/cf-terraforming#443 validation mismatches, I
went ahead and updated
CertificatePacksto only reference ACMconfiguration now that dedicated custom/custom certificates are no more.